search

chiefonboarding / ChiefOnboarding

Free and open-source employee onboarding platform. Onboard new hires through Slack or the web portal.
https://chiefonboarding.com
GNU Affero General Public License v3.0
640 stars 119 forks source link

Fix missing expiring key for integration builder #425

Closed GDay closed 5 months ago

GDay commented 5 months ago

It couldn't compare the integration.expiring value as it creates a mock item (which doesn't get saved, so no new value was added).

This will first check if it needs to be renewed (and will renew if necessary), so this will be skipped on the actual test call.

The builder is still in beta, so forgoing adding tests right now.

coveralls commented 5 months ago

Coverage Status

coverage: 92.242% (-0.07%) from 92.308% when pulling af992cf7747a87883fc1f1c9ad02d441c8563f1f on fix-missing-expiring-key into 08263164b743e67a0fd1caa43a8eb3527cd7a93a on master.