search

chieftools / pkgtrends

A quick way to compare package downloads across languages.
https://pkgtrends.app
11 stars 1 forks source link

Add nugettrends.com as NuGet provider #7

Closed stayallive closed 2 years ago

stayallive commented 5 years ago

Fixes #6

bruno-garcia commented 5 years ago

Cool stuff! One thing though: Do you think it would be possible to link to NuGetTrends as the data source instead? Just wondering if there's a way to give the site some sort of credit :)

stayallive commented 5 years ago

If you look at the $sources in the class you can see I link to NuGetTrends as the source, that link wil be displayed in the footer with the rest of the data sources. It still does say NuGet instead of NuGetTrends not sure how I want to do it if the source is "unofficial", so that might change still before we're pushing this live 👍

https://github.com/irongate/pkgtrends/pull/7/files#diff-6fee2a9fee79be93a1e7e1b4dd50be69R29

bruno-garcia commented 5 years ago

If you look at the $sources in the class you can see I link to NuGetTrends as the source, that link wil be displayed in the footer with the rest of the data sources.

Right, I missed that, sorry.

It still does say NuGet instead of NuGetTrends not sure how I want to do it if the source is "unofficial", so that might change still before we're pushing this live 👍

OK, no biggie. Thanks!

stayallive commented 2 years ago

I am going to close this since there hasn't been any movement, #6 remains open to track the feature request in case we want to restart this again!