chiefwigms / picobrew_pico

MIT License
149 stars 63 forks source link

Feature Request: Make it so that the Pico reminds you to clean every 3 sessions. #217

Closed Rudder2 closed 3 years ago

Rudder2 commented 3 years ago

I love your PIServer if you can't tell from how much I use it...It would be nice if after 3 brews the PIServer would display a message on the PicoBrew machine like it use to when connected to the "Mothership". It would also be nice if on the main PIServer screen if said brews since clean. Just would be nice as a reminder. I sometimes forget the number of brews since a clean. I think the most I forgot was 6 brews and I remembered when a Pale came out darker than expected. I just count the sessions since last clean in the Brew history now, as long as they all show up that works.

chiefwigms commented 3 years ago

Screenshot_20210122-211705_Chrome 🤣.. when I wrote it 3 years ago

tmack8001 commented 3 years ago

This did work for the Z... All the invalid session files likely break this.

Rudder2 commented 3 years ago

I have no more invalid sessions and after 3 brews it still doesn't prompt to clean the Z. 2021-02-06 3 Brews since clean

tmack8001 commented 3 years ago

Hrm I'll take a peek, likely a refactor along the way broke it. Or maybe the rinse is being tracked as a clean 🤔. I'll check which sessions are marked as "dirty" and see about adding a fix for this.

As I don't have a working C/S/Pro, I'm not sure what the response should be when a clean is in order so for now I can just test this physically with a Z.

tmack8001 commented 3 years ago

https://github.com/chiefwigms/picobrew_pico/pull/241 is attempting to fix both of these issues (Z and Pico)

tmack8001 commented 3 years ago

Just got the merged today. Pull the latest and see if this is resolved for you. I tested with physical files, but I don't have a Pico to test with directly

sickchilly commented 3 years ago

When I powered on my C with this update, it prompted me to deep clean. I have 4 session on the server at the moment. 3 brews and 1 deep clean. So perhaps it’s fixed?

chiefwigms commented 3 years ago

@tmack8001 made a t based off file names, so if you don't have a clean session within the last 3 (based on date) sessions, you'll get harassed

sickchilly commented 3 years ago

That logic is sound. I am correctly getting harassed: 86240555-63C3-4A0B-B1B6-3D19934F1040

tmack8001 commented 3 years ago

@sickchilly later I want to make it user specified. So you could say "deep clean after every 1 dirty session".

There are a few utility functions I'm treating as "non dirty" sessions: rack, drain, rinse, etc. I might not be covering them all as there are some I have never used 🤣. Eventually with this user controlled clean I'd want to also give check boxes for you the user to mark which of those you classify as "dirty sessions" in other words some people don't want to run a clean after day 3 coffee (a utility function on Z units) sessions 🤷‍♂️. My hope is that there is more and more of these user defined settings going forward that will help to allow you (the user/owner/brewer/assistant/etc) control over the device you paid for unlocking future potential and features that PB never even dreamed of providing to us.

sickchilly commented 3 years ago

Well, this still may not be working as intended. I just did a deep clean today yet it still prompts me to deep clean each time I power on my C. FC815450-5348-41BC-8370-B64AB2E5A845