search

chiefwigms / picobrew_pico

MIT License
149 stars 63 forks source link

Setup Hostname has some interesting, invalid display #239

Closed sickchilly closed 3 years ago

sickchilly commented 3 years ago

Version 2d145e4

Setup Hostname: Screen Shot 2021-02-05 at 18 31 32

Actual hosts file: Screen Shot 2021-02-05 at 18 32 15

tmack8001 commented 3 years ago

I changed this to be compatible with deployment scenarios and thought I tested on my Pi as well.

I'll double check things and see about fixing that. Though for your setup @sickchilly you still have your local dns set to a different name though yes, picobrew_server?

ZuruckBleibenBitte commented 3 years ago

I'm also seeing this issue -- and it also shows incorrectly in the About screen...

I changed my hostname to "pibrew" since we have about multiple Pis , so wanted to be able to ID between them (I think we have 4...). If I try to change it back to "pibrew" in the Server and hit Save, I get a server error.

I also SSH'd into the Pi and checked the hostname setting and it shows correct on the Pi, so I think this is just a display issue.

sickchilly commented 3 years ago

Not sure I follow what you mean by local DNS. Yes, I do run my own ad blocker/DNS (PiHole) on my network, but that is separate from the picobrew Pi server. I still connect my devices directly to the Pi's WiFi as intended. The only things I've changed on my Pi server are what's available in the set section... WiFi name/password and hostname. And I haven't edited those things in 2 months. It just started displaying this weird hostname with the 2d145e4 update.

tmack8001 commented 3 years ago

Ah ok then the merged change to this impacted that, but still is incorrect given the hostname set for your device.

I'll take a look thanks for reporting.

tmack8001 commented 3 years ago

Check out the latest that was merged today

ZuruckBleibenBitte commented 3 years ago

This is fixed for me...

sickchilly commented 3 years ago

Also fixed for me. Thanks.