search

chiefwigms / picobrew_pico

MIT License
149 stars 63 forks source link

Collapse inactive devices by default #249

Closed cgalpin closed 3 years ago

cgalpin commented 3 years ago

and some refactoring to lessen duplicate markup and improve readability.

Before the devices were all expanded when you load the page, which makes you scroll to get to the info you want - like if you are fermenting, and not brewing.

This merge request collapses inactive devices so the active ones are more prominent.

cgalpin commented 3 years ago

Great suggestion and it also helped me see the iSpindel bug (which I am unable to test). But you are too fast. I saw you had made partial mods so went and made the changes locally. What's the preferred approach - commit your suggestions here, or merge them?

tmack8001 commented 3 years ago

To resolve the "merge checks" either I need to "approve changes" (just did) or you could have "accepted changes" 1 by 1 in a "batch".

Though things look good with your local committed changes. Thank you sir.