chiefwigms / picobrew_pico

MIT License
149 stars 63 forks source link

Server recipe Header documentation #257

Closed LEFsher closed 3 years ago

LEFsher commented 3 years ago

As promised on FaceBook here is my stab at documenting the Fields/Headers in the server recipe builder. Let me know if this works or if I am way off on my descriptions :) Cheers Receipe header.docx

Intecpsp commented 3 years ago

With a "pause" do any of the other columns actually matter since it waits on the user?

LEFsher commented 3 years ago

As far as I am aware no as the system is waiting on user input.

Intecpsp commented 3 years ago

Also, which devices actually support a 'pause'? I don't have the option on my C, but can see it as one for the Zymatic and Z. /cc @tmack8001

tmack8001 commented 3 years ago

Only Zy/Z I believe have a programmatic pause function, though all should have a local pause I think.

I haven't use a C/S/Pro successfully yet as all of mine leak and just haven't gotten to fixing them yet need to finish my workspace renovation first otherwise they are just in the way.

sickchilly commented 3 years ago

If the C/S/Pro units support a programmatic pause, it sure would be handy for things like adding lactose to the keg at start of boil or circulating and simulating hop stand/whirlpool steps. If anyone wants to send me some rogue code, I’d be happy to test it.

cgalpin commented 3 years ago

On my Pico S/Pro you can pause during the brew using the menu on the pico. I am not sure if that means programmatic or not. Mine has died so I can't do a test to see what messages are sent to the server, but I will once i get it working again.

tmack8001 commented 3 years ago

programmatic would mean adding a step with a location of "PAUSE" like in the Zy and Z. I'm fairly confident that isn't supported in those Firmware, but I could be wrong.

Does anyone remember if brewing a picopak there was a step "Chill" that would pause and ask for an inline or jaded chiller added? I don't think so cause at those volumes why bother, right?

Intecpsp commented 3 years ago

I never saw one, but I know you can from the device menu. Why support it only on device and not recipe?

tmack8001 commented 3 years ago

cause these machines were never meant to be used in this manner 🤷‍♂️

chiefwigms commented 3 years ago

Exactly.. not sure why all the fuss about a pause that doesn't exist. Can't you manually pause it anyway (via rotary dial)?

tmack8001 commented 3 years ago

Added a bit additional language in the existing tooltips (if you hover over a header or cell in the table "help text is displayed").

https://github.com/chiefwigms/picobrew_pico/pull/263

Intecpsp commented 3 years ago

The benefit of having an auto pause on the lower tier devices would be to get pre-boil measurements without me having to monitor the device for the correct time. If it could just pause and set of the alarm for notification, that would be ideal. I don't understand why they would allow it from the machine, but not recipe. Seems like they could've used the same hook from the recipe they do from the UI. But I understand that if it's not there, there is nothing we can do. I'll just set up an external alarm to try and catch it before it starts the boil.

tmack8001 commented 3 years ago

@Intecpsp I have eventual dreams of setting up browser notifications (which then potentially gives mobile as well) for specific events (new step, user defined step starting, brew complete).

Though obviously I haven't had the time to devote to this as I have lots of other side projects that are distracting from the more important hobby of "brewing good beer".

LEFsher commented 3 years ago

Just checked the latest iteration of the Pi interface (1b49ff8). There is an issue with the pop out when hovering over temperature in the recipe fields, using degrees F gives the correct range of 0 to 208, but when switching to C it gives [-17.78 - 37.78].... -17.78 is 0 F however 37.78 = 100F. So when trying to enter any number larger than 37.78 if will not accept it. I did not find any other issues and not certain if this may cause issues during a brew...

tmack8001 commented 3 years ago

I'll take a gander tonight @LEFsher . Thought I fixed that when I was looking at this, but I'll double check.

LEFsher commented 3 years ago

👍

tmack8001 commented 3 years ago

When testing what you reported @LEFsher I found that only the tooltip was wrong, but adding a value higher than that was accepted just fine.

Let me know, but I have added a PR for review for the tooltip change which was fairly straight forward.

LEFsher commented 3 years ago

Interesting I just reset my Pi it is now on build (8fe2e08) and if I open a new recipe all is good... unless the temperature is set to Metric, then the recipe opens with the temperature populated numbers showing Imperial (207 etc.) but the scale is metric, then if I change to imperial on the scale the numbers are as 404 as opposed to 207 etc. Then if you click in the populated cell the number changes from 404 to 207.... Not a big issue if you keep the scale on Imperial but confusing....🤪 Receipe headers.pdf

tmack8001 commented 3 years ago

Yeah there are some weird things around keeping and refreshing the state.

If you load in F and convert to C it should display correctly.

Too bad there wasn't a good formatter for tabular tables so I have to hack in something to work. There are definitely edge cases that don't quite work correctly, but with enough fudging you can get the right data reliably.

LEFsher commented 3 years ago

Yes it does I only noticed it as I had left it set to C so when I loaded the table it had the weird numbers, no problem but it does sound like an interesting issue to try and work around. The last time I did any coding was a very long time ago so I sort of remember some of the issues. Have fun Cheers