search

chiefwigms / picobrew_pico

MIT License
149 stars 63 forks source link

Zseries Session Start Time Mismatch #306

Closed wiltdavi closed 2 years ago

wiltdavi commented 3 years ago

I am new to collaborating on a GitHub project so please correct me if this is not the proper procedure. I created a pull request, #304, to fix this issue but have not seen any comment on it so I am assuming I need to create an issue that the pull request is fixing. Again, correct me if this is not what you want me to do.

The issue is for a Zseries session the start time of the session would mismatch what was shown in the graph. When the session was completed and reviewed in the history or if the session was recovered the start time would match the graph. This mismatch only occurs during the initial session creation.

image

Pull request #304 fixes this issue.

chiefwigms commented 2 years ago

Thanks for the fix! Sorry, I've been pretty busy lately with a new baby/kid

cgalpin commented 2 years ago

Congrats!

wiltdavi commented 2 years ago

No problem. I see the pull request was merged without this ticket so I will not create a separate issue ticket in the future. I hope to assist more.

Also, congratulations on the new one!

As the pull request has been merged I will close this ticket.

tmack8001 commented 2 years ago

Thanks for your detailed reporting and contributions @wiltdavi . Appreciate it. Also been busy here as well, but with school (kindergarten) started today hopefully a routine sets back in.