search

chiefwigms / picobrew_pico

MIT License
149 stars 63 forks source link

Tilt History Fails to Load after Issue #288 Update #318

Closed wiltdavi closed 2 years ago

wiltdavi commented 2 years ago

When selecting the Tilt History the Load more... button is shown but the history is not. When you click the button the Loading... occurs but nothing is loaded. I have confirmed that this issue was introduced with the merge of issue #288, version 03950fe, and the issue still exists with the latest code version 145929b. The Brew History works as expected.

image

wiltdavi commented 2 years ago

I am going to see if I can debug the issue but I wanted to document it first.

tmack8001 commented 2 years ago

thanks for raising this @wiltdavi . I do see this behavior locally here as well so something definitely isn't working as expected with the new paginating and centralized session history implementation/refactor (of course I broke something trying to delete as much code as humanly possible).

tmack8001 commented 2 years ago

After tracing the calls within routes_frontend.py it was fairly obvious what was wrong...

Fix posted in https://github.com/chiefwigms/picobrew_pico/pull/319 take a gander if curious TLDR brew_sessions != tilt_sessions 🤣 🤦

wiltdavi commented 2 years ago

@tmack8001 it is an easy fix when you know where to look. Glad I can help out in some way. Thanks for the quick fix.