Download History File Button Broken after Issue #288 Update

chiefwigms / picobrew_pico

MIT License

149 stars 63 forks source link

Download History File Button Broken after Issue #288 Update #321

Closed wiltdavi closed 2 years ago

wiltdavi commented 2 years ago

When clicking on the download file button in the session history

the file is not downloaded and you are redirected to a page displaying this:

I have confirmed that this issue was introduced with the merge of issue #288, version 03950fe, and the issue still exists with the latest code version 683aada. With the latest code I have been able to confirm this issue occurs in both the Brew History and Tilt History.

wiltdavi commented 2 years ago

I don't use this feature, as I just use samba, but I wanted to report the broken feature I found.

tmack8001 commented 2 years ago

Likely a missed rebase change when I had multiple branches running at the same time all refactoring the same stuff... Likely a single line that got missed due to no tests of actual functionality.

Will get this resolved this morning.