search

chiefwigms / picobrew_pico

MIT License
149 stars 63 forks source link

Paginated Sessions Don't Render Graphs #324

Closed tmack8001 closed 2 years ago

tmack8001 commented 2 years ago

see original comment from @wiltdavi here, https://github.com/chiefwigms/picobrew_pico/pull/250#issuecomment-977816777

tmack8001 commented 2 years ago

fixing this issue in https://github.com/chiefwigms/picobrew_pico/pull/323

wiltdavi commented 2 years ago

@tmack8001 I took the code from your pull request #323 and when I use it I see the same thing I reported in #250 (comment). Here what I see when using your code from #323.

image

Please note, I do not see this with the current master version ae8b2c3. That version of master is working just file.

To make sure you understand what I meant in my original comment, here is an example of how to reproduce what I am doing.

From the current master the graph is visible.

image

Switch to the a36b316 version and the graph is not visible.

image

As I previously stated, I compared the data files to a local backup I have created and I do not see any differences in them so I am not sure why going backwards in the code is causing the graph to be as this version worked before I upgraded to the latest code.

I am still learning so let me know if I am doing something wrong here.

wiltdavi commented 2 years ago

After discovering that my browser cache was causing the graph issue I reported here I retested the code from PR #323 and I see no issues with it.