search

chiefwigms / picobrew_pico

MIT License
149 stars 63 forks source link

Tilt graph improvements #325

Closed wiltdavi closed 2 years ago

wiltdavi commented 2 years ago

The following improvements have been made to the Tilt graph:

  1. Improved auto scaling
  2. Tooltip shows both series, temperature and specific gravity
  3. Graph subtitle displays all last received data

Before the changes: image

After the changes: image

Based on experimentation 6 division on the y-axis were determined to provide good resolution without cluttering the graph. The number of divisions are hardcode to this value and therefore there will always be 6 division. Due to this when there is only a single data point or all the data points are of the same value, the data will be on the x-axis with blank space above it.

image image

Once there is at least single data point of deviation the full graph space will be utilized.

image

tmack8001 commented 2 years ago

@wiltdavi thanks for these changes. The visual improvements in both the tooltip (brings inline with other device types) and the "subtitle" are great welcomed additions.

I'll review the code after tonight's date night with the wife or more realistically tomorrow morning before kids wake up or while they watch Saturday cartoons.

BuckoWA commented 2 years ago

Think we should incorporate the same view into the iSpindel? I can make those changes if desired. Like the look and think consistency wouldn't hurt either.

wiltdavi commented 2 years ago

I don't have a iSpindel for reference but I would agree that this is something that could be carried over to other devices.

It took me a while to figure out how the highcharts api worked so if you make the changes for the iSpindel let me know if you have any issues with it.

BuckoWA commented 2 years ago

I don't have a iSpindel for reference but I would agree that this is something that could be carried over to other devices.

It took me a while to figure out how the highcharts api worked so if you make the changes for the iSpindel let me know if you have any issues with it.

I have iSpindels and can test it. I'll look into it and appreciate you digging into the api.

chiefwigms commented 2 years ago

looks good to me.. i'll let @tmack8001 take a gander. thanks!

tmack8001 commented 2 years ago

LGTM as well 👍 merged