Closed wiltdavi closed 2 years ago
@wiltdavi thanks for these changes. The visual improvements in both the tooltip (brings inline with other device types) and the "subtitle" are great welcomed additions.
I'll review the code after tonight's date night with the wife or more realistically tomorrow morning before kids wake up or while they watch Saturday cartoons.
Think we should incorporate the same view into the iSpindel? I can make those changes if desired. Like the look and think consistency wouldn't hurt either.
I don't have a iSpindel for reference but I would agree that this is something that could be carried over to other devices.
It took me a while to figure out how the highcharts api worked so if you make the changes for the iSpindel let me know if you have any issues with it.
I don't have a iSpindel for reference but I would agree that this is something that could be carried over to other devices.
It took me a while to figure out how the highcharts api worked so if you make the changes for the iSpindel let me know if you have any issues with it.
I have iSpindels and can test it. I'll look into it and appreciate you digging into the api.
looks good to me.. i'll let @tmack8001 take a gander. thanks!
LGTM as well 👍 merged
The following improvements have been made to the Tilt graph:
Before the changes:![image](https://user-images.githubusercontent.com/7861456/145610699-201d3b60-8aed-4ae3-aab9-4c6f34b1ef41.png)
After the changes:![image](https://user-images.githubusercontent.com/7861456/145612380-1d7dffca-9d81-421e-86e9-35e37875ee4f.png)
Based on experimentation 6 division on the y-axis were determined to provide good resolution without cluttering the graph. The number of divisions are hardcode to this value and therefore there will always be 6 division. Due to this when there is only a single data point or all the data points are of the same value, the data will be on the x-axis with blank space above it.
Once there is at least single data point of deviation the full graph space will be utilized.