search

chiefwigms / picobrew_pico

MIT License
149 stars 63 forks source link

include clean and rinse detection to zymatic device #326

Closed tmack8001 closed 2 years ago

tmack8001 commented 2 years ago

haven't tested with a zymatic physically

I'm getting a Zymatic on Tuesday and will be able to run some tests with clean and rinse sessions to get the format right.

tmack8001 commented 2 years ago

Thanks lint checker. Yup I'll fix when I get back to computer later.

tmack8001 commented 2 years ago

image image

Tested the two cases: clean machine and a dirty session machine

Not sure how that original conditional wasn't caught earlier if mtype == MachineType.PICOBREW_C or MachineType.PICOBREW would always eval to true 🤪, fixed that and the method call error below it in ZSeries calculation. The PicoBrew dirty calculation worked for Z units cause it was based on the session name which happens to be the same for those units and not leveraging the SessionType int that is in the session file.

With that conditional fixed I've also verified the ZSeries detection is working as well (bunch of test case devices in local sessions directory). image image image image

This PR should be good to merge now 🤔