chiefwigms / picobrew_pico

MIT License
149 stars 63 forks source link

correct the troubleshooting link for pico-s devices #337

Closed tmack8001 closed 2 years ago

tmack8001 commented 2 years ago

before image

after image

tmack8001 commented 2 years ago

Darn python dependencies... Import issues with janja2 🤬😤

../../../hostedtoolcache/Python/3.7.12/x64/lib/python3.7/site-packages/flask/__init__.py:14: in <module>
    from jinja2 import escape
E   ImportError: cannot import name 'escape' from 'jinja2'
tmack8001 commented 2 years ago

https://pypi.org/project/Jinja2/#history Jinja2 3.1.0 was released on March 24th which leads to this issue due to Flask incompatibility that isn't pinned by our requirements.txt

/home/runner/work/picobrew_pico/picobrew_pico/app/main/routes_frontend.py:183: DeprecationWarning: 'jinja2.escape' is deprecated and will be removed in Jinja 3.1. Import 'markupsafe.escape' instead.
    recipe.name_escaped = escape(recipe.name).replace(" ", "_")

 ...

   /opt/hostedtoolcache/Python/3.7.12/x64/lib/python3.7/site-packages/flask/json/__init__.py:376: DeprecationWarning: 'jinja2.Markup' is deprecated and will be removed in Jinja 3.1. Import 'markupsafe.Markup' instead.
    return Markup(htmlsafe_dumps(obj, **kwargs))
chiefwigms commented 2 years ago

https://pypi.org/project/Jinja2/#history Jinja2 3.1.0 was released on March 24th which leads to this issue due to Flask incompatibility that isn't pinned by our requirements.txt

/home/runner/work/picobrew_pico/picobrew_pico/app/main/routes_frontend.py:183: DeprecationWarning: 'jinja2.escape' is deprecated and will be removed in Jinja 3.1. Import 'markupsafe.escape' instead.
    recipe.name_escaped = escape(recipe.name).replace(" ", "_")

 ...

   /opt/hostedtoolcache/Python/3.7.12/x64/lib/python3.7/site-packages/flask/json/__init__.py:376: DeprecationWarning: 'jinja2.Markup' is deprecated and will be removed in Jinja 3.1. Import 'markupsafe.Markup' instead.
    return Markup(htmlsafe_dumps(obj, **kwargs))

we should just merge my 3rd party branch

tmack8001 commented 2 years ago

reverted all the version changes and rebased on top of the new master with the 3rd party changes in place