chiefy / vaulted

nodejs based wrapper for HashiCorp's Vault HTTP API
https://chiefy.github.io/vaulted
MIT License
47 stars 6 forks source link

Upgrade request-promise dependency to 2.x #79

Closed blimmer closed 8 years ago

blimmer commented 8 years ago

1.x outputs this error on npm install:

└─┬ vaulted@3.0.0
  ├─┬ confab-addons@0.1.0
  │ ├─┬ confab@0.1.0
  │ │ └── object-assign@4.0.1
  │ ├── js-yaml@3.5.3
  │ └── lodash@3.10.1
  ├── js-yaml@3.5.3
  ├── lodash@3.10.1
  ├─┬ request-debug@0.2.0
  │ └── stringify-clone@1.1.1
  └─┬ request-promise@1.0.2
    ├── bluebird@2.10.2
    ├─┬ cls-bluebird@1.0.1
    │ └── shimmer@1.1.0
    ├── UNMET PEER DEPENDENCY continuation-local-storage@~3
    └── lodash@3.10.1
UNMET PEER DEPENDENCY continuation-local-storage@~3

The issue is reported here and supposedly fixed in 2.x.

kenjones-cisco commented 8 years ago

Thanks! We have no dependency on continuation-local-storage so the change should be pretty straight forward. Thanks! :+1:

blimmer commented 8 years ago

Yep - opened #80 to run tests - having some problems getting docker up and running to test locally.

kenjones-cisco commented 8 years ago

Resolved via #80