search

chiefy / vaulted

nodejs based wrapper for HashiCorp's Vault HTTP API
https://chiefy.github.io/vaulted
MIT License
47 stars 6 forks source link

chore(testing): Add tests for mounts to improve coverage #8

Closed kenjones-cisco closed 8 years ago

kenjones-cisco commented 8 years ago

Adds testing for mounts modules to provide better overall coverage for the library. Also resolves issues deleting mounts, reMount, and creating.

kenjones-cisco commented 8 years ago

After merging in the changes from the other testing changes from last night and re-running, I noticed that these will continue to pass as expected but secret test cases will fail.

The changes included in the consul branch include a friendlier approach to using init that allows multiple calls to init to work easier.

I can work on breaking up the consul branch such that the changes to init and seal are separate, then swapping the init logic for the test cases should result in all tests passing as expected. Otherwise we can merge this after the consul branch, assuming the init approach is agreeable.