search

chigy / winui-redline

An app that generates design values for WinUI.
MIT License
3 stars 0 forks source link

Add color redlines #15

Closed kaiguo closed 5 years ago

kaiguo commented 5 years ago

V1: 20190724150740

V2: 20190724145742

chigy commented 5 years ago

Very cool. BTW, is it possible to make the line not overlap the text? I am talking about here. Is there a way to guarantee text and line always avoid themselves somehow? (nice to have for v1 if hard :))

image

chigy commented 5 years ago

Can this be in red text and maybe inside a box? image

chigy commented 5 years ago

Why are color names different between what's in redline and what's in the list of text?

image image

chigy commented 5 years ago

BTW, none of the comment I made should stop submission. I can open issues if you want instead. :) Just didn't want to lose the feedback... Very cool!!!

kaiguo commented 5 years ago

Very cool. BTW, is it possible to make the line not overlap the text? I am talking about here. Is there a way to guarantee text and line always avoid themselves somehow? (nice to have for v1 if hard :))

image

I think it's possible, i'll try fixing it : )

kaiguo commented 5 years ago

Why are color names different between what's in redline and what's in the list of text?

image image

The names in the list are full names in generic.xaml. I stripped out "SystemControl" and "brush" parts in redline to make them shorter. But yeah, I can update the list to make those names consistent.