fix: adjust declaration template

chihab / dotenv-run

Seamlessly load environment variables. Supports cli, esbuild, rollup, vite, webpack, angular. ESM and Monorepos.

241 stars 17 forks source link

fix: adjust declaration template #25

Closed chernodub closed 1 year ago

chernodub commented 1 year ago

Hi 👋
I faced an issue with the up-to-date approach of merging process types. But, recently, I figured out a cleaner way to merge declarations of NodeJS.Process. This is a TS feature that would allow achieving the desired behavior. This closes #16 and closes #22.

loban commented 1 year ago

This is a perfect fix. What can we do to get this merged? Is it to do with the failing build check?

chihab commented 1 year ago

Thanks @chernodub for the idea, I took the liberty of putting it in the v15 version to get the build through. I'm testing it with the earlier versions. If it works well, we can keep the README updated in the PR, I'd love to have your contribution back.

chihab commented 1 year ago

It looks like, depending on the Angular CLI version, we have one of these two errors:

"No process defined " fixed by the old .env.d.ts. v12 & v13
"Subsequent variable declarations" which is fixed with your solution. >= 13

Could you please update the README file to reflect your update since most of users use >= 13?