Refresh donate page

[easherma]

Fixes #557

[easherma]

small css change.

also the PR indicates that the donate page is changed, but no changes have been made to that page, just the top nav. before making the page more prominent, we should update the content on the page

Yes sorry. I should mark this as a draft. I noted the things I'd still like to do on this PR here: https://github.com/chihacknight/chihacknight.org/issues/557#issuecomment-1736567257

On Fri, Sep 29, 2023 at 1:54 PM Derek Eder @.***> wrote:

@.**** requested changes on this pull request.

small css change.

also the PR indicates that the donate page is changed, but no changes have been made to that page, just the top nav. before making the page more prominent, we should update the content on the page

In css/custom.css https://github.com/chihacknight/chihacknight.org/pull/558#discussion_r1341702021 :

@@ -9,12 +9,14 @@ body { .navbar-brand img { height: 40px; }

.navbar-nav > li > a {

• padding-bottom: 10px;
• padding-top: 10px;
• padding: 10px 10px 10px 10px;

this could be simplified to padding: 10px;

— Reply to this email directly, view it on GitHub https://github.com/chihacknight/chihacknight.org/pull/558#pullrequestreview-1651328356, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACQNGT5WQYMWMI7MBBR23RLX44KNTANCNFSM6AAAAAA5IVJATM . You are receiving this because you authored the thread.Message ID: @.***>

-- Eric Sherman 224-402-0004

[derekeder]

ah - sorry for the premature review!

[swatland610]

@easherma I think this generally looks great! A couple of notes:

1. I think we should remove the EventBrite one - I tried clicking through to it and it says the Event no longer exists. Probably because it was in the past. I think we may continually run into this issue, so I think just removing it makes sense for now!

Could you point me to what file I'd need to change if I'd want to make some copy edits? I'm unclear on how this part is structured. Thanks!

[easherma]

@swatland610 check out the changes on the PR to see what file to edit.

@derekeder looked at this with Sean and Michael today and we think its pretty good for an initial version of refreshing this page!

[derekeder]

@easherma looks good to me! my only thought - is there a better venmo image to use that indicates that clicking it will take you to a donate page? the difference between the two buttons is kinda noticeable

[easherma]

@derekeder I don't see a button at first glance but I'm sure we could find one or whip something together. Does this feel blocking for the rest of the PR or something we can improve as we go?

[derekeder]

nah, we can bring it in as is