chihacknight / decarbonize-my-state

What does it take to decarbonize your state?
https://decarbmystate.com/
MIT License
13 stars 1 forks source link

source citation for charts #161

Closed derekeder closed 1 year ago

derekeder commented 1 year ago

Overview

Adds "Source" citations to the home page map, as well as for the charts on the state detail pages.

Closes #132

Demo

Screen Shot 2022-10-10 at 10 03 40 PM Screen Shot 2022-10-10 at 10 06 09 PM

Testing Instructions

netlify[bot] commented 1 year ago

Deploy Preview for decarb-my-state ready!

Name Link
Latest commit 87bf7e0e12f00faff04becc8afa067336e886f8e
Latest deploy log https://app.netlify.com/sites/decarb-my-state/deploys/6358460ab0eecd000886cc62
Deploy Preview https://deploy-preview-161--decarb-my-state.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

vkoves commented 1 year ago

@derekeder - should we move the citation data into a constant, so it's together with the actual data sources? I suggested to Robert making a combined object in this comment: https://github.com/chihacknight/decarbonize-my-state/issues/132#issuecomment-1229232296

That would prevent us updating one page and not the other

vkoves commented 1 year ago

@derekeder - pinging you on my comment above - I'd like to see us move to a common object before this is merged

derekeder commented 1 year ago

@vkoves ok took care of your comments. We now have a source-citations.js constants file and two helper methods: getShortCitation and getLongCitation. All source citings, including the about page, now use this.

derekeder commented 1 year ago

celebrate