chihacknight / decarbonize-my-state

What does it take to decarbonize your state?
https://decarbmystate.com/
MIT License
13 stars 1 forks source link

Show Progress Needed This Year On Graphs To Provide More Context #181

Closed SuragNuthulapaty closed 1 year ago

SuragNuthulapaty commented 1 year ago

Overview

Updates the progress bars to look less gloomy and give an indicator on how much progress is needed in the next year Closes #169

Demo

Screenshot 2023-02-07 at 9 25 17 PM

Testing Instructions

go to any state page and check each of the progress indicators

netlify[bot] commented 1 year ago

Deploy Preview for decarb-my-state ready!

Name Link
Latest commit 146e6be381f2e0041f31878cabde8f41b5bb4e42
Latest deploy log https://app.netlify.com/sites/decarb-my-state/deploys/63ed9887d0a6b200075c4fa9
Deploy Preview https://deploy-preview-181--decarb-my-state.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

vkoves commented 1 year ago

@SuragNuthulapaty - the new section is missing on the power section, can you add it to that?

Screenshot from 2023-02-08 14-10-23

I also think two slight CSS tweaks make this look better:

fill: #6c757d;
font-size: 0.75rem;

This increases a font a touch to 12px, which is a good minimum text size, but lightens the text.

Screenshot from 2023-02-08 14-12-41

derekeder commented 1 year ago

I think this is moving in a good direction, but the addition of a third color makes this bar chart a bit harder to parse. We need to label each section somehow. The note under the bar is not enough. A few ideas:

vkoves commented 1 year ago

Subtle, but the MWs graph is getting cut off at the top:

Screenshot from 2023-02-14 21-03-00

vkoves commented 1 year ago

@SuragNuthulapaty - sorry, I also noticed the colors of the graphs are different 😆

Screenshot from 2023-02-14 21-18-39

Screenshot from 2023-02-14 21-18-34 Maybe we really should move those into one component, but I'll leave that up to you if you want to take that on.

There's also no right label on that graph but maybe you and @derekeder discussed not needing that for the power graph 🤷🏻‍♂️

derekeder commented 1 year ago

I agree we could use some consistency here. It might look better to not have the right label shown at all.

Moving everything into a single component will probably make these changes easier, but up to you @SuragNuthulapaty

SuragNuthulapaty commented 1 year ago

Sounds good, I’ll move both charts into one component

SuragNuthulapaty commented 1 year ago

@derekeder I combined the graphs, if you want to take a look at this now