search

chihacknight / decarbonize-my-state

What does it take to decarbonize your state?
https://decarbmystate.com/
MIT License
13 stars 1 forks source link

Visual Improvements to Graph #194

Closed hkier closed 1 year ago

hkier commented 1 year ago

Overview

This PR was created to clarify visually the data in the graph to show some data is assumed. At the same time, area labels were rotated back and made more readable.

Closes #152

Demo

Before After
image image

Notes

Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.

Testing Instructions

visually check various state pages

netlify[bot] commented 1 year ago

Deploy Preview for decarb-my-state ready!

Name Link
Latest commit 5bc5161244d47c02db3b4ed62122643bf5669523
Latest deploy log https://app.netlify.com/sites/decarb-my-state/deploys/644c9111b435550008216e88
Deploy Preview https://deploy-preview-194--decarb-my-state.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

vkoves commented 1 year ago

@hkier - this looks great overall, but can you undo the changes to yarn.lock? I think that happened from running npm install rather than yarn install, as it looks like it's just pointing to different URLs.

I'd also ask you update the PR title so it's clear to us in the future what changes this PR made!

vkoves commented 1 year ago

@hkier - sorry I missed your change, I have GitHub to only ping on requests for review. You've now deleted the yarn.lock, but I was trying to say that this PR shouldn't change that file at all - I think the easiest way to approch that would be to just copy paste the exact yarn.lock file from main. Alternatively, running yarn install (rather than npm install) may properly re-create the lock file, but I'm not positive. We can discuss tomorrow in person too!