search

chihirobelmo / FalconBMS-Alternative-Launcher

Configure and save FalconBMS setup per Joysticks.
Other
130 stars 30 forks source link

[critical] Data loss when selecting BMS versions on main screen listbox; and this happens non-predictably #114

Closed arithex closed 10 months ago

arithex commented 10 months ago

1- modify some bindings 2- go back to home "Launcher" screen 3- select another BMS version (purposeful or accidental) 4- restore selection to the previous version

Observed: none of our changes were saved Expected: our changes are saved

Making this worse: depending on how the startup codepath goes (probing the registry and saved-prefs file for last selection).. the listbox may not have an initial selection at all -- when you go to actually save/exit or launch BMS, the selection-change event kicks in, and you lose all your recent changes.

arithex commented 10 months ago

Note this is not a regression for U3.. AL 2.2-2.3 seems to suffer from this problem.

Pretty sure I've seen this happen, but was never able to repro because of the winding codepaths on startup...

arithex commented 10 months ago

Fixed in https://github.com/chihirobelmo/FalconBMS-Alternative-Launcher/pull/112