search

chihirobelmo / FalconBMS-Alternative-Launcher

Configure and save FalconBMS setup per Joysticks.
Other
130 stars 30 forks source link

Shifted pov hats bindings not working #93

Closed arithex closed 11 months ago

arithex commented 1 year ago

https://github.com/chihirobelmo/FalconBMS-Alternative-Launcher/blob/master/Falcon%20BMS%20Alternative%20Launcher/Input/JoyAssgn.cs#L288

The code here is pretty convoluted and confusing. It looks like there’s an array of 4 PovAssgn objects which was (presumably) intended to represent the 2 devices x 2 shift-states… so far so good.

But then the triple-nested for loop attempts to writeout 2 shift states for each of those 4 PovAssgn elements?

The code is further complexified by what looks like a one-line hack to avoid writing SimDoNothing over a previously emitted callback… but that hack doesn’t seem to work.

The code is 90% duplicated then again below… for the case of pov hats on 2 separate devices. But I'm not sure I see why, the key file output should be the same. Only cfg entries would be different.

arithex commented 1 year ago

Submitting https://github.com/chihirobelmo/FalconBMS-Alternative-Launcher/pull/101 for review

arithex commented 11 months ago

fixed in pull/101 .. although maybe now I created different issues :/