In-game graphics settings for "Show Mirrors" is overwritten each launch

chihirobelmo / FalconBMS-Alternative-Launcher

Configure and save FalconBMS setup per Joysticks.

Other

130 stars 30 forks source link

In-game graphics settings for "Show Mirrors" is overwritten each launch #97

Closed arithex closed 11 months ago

arithex commented 1 year ago

https://forum.falcon-bms.com/post/375958

4.37 added a new option for "mirrors", but there's no corresponding checkbox in Alt Launcher, so it gets zeroed each launch.

I would propose: AL shouldn't duplicate and overwrite all those pop file options -- we should surgically update what we need to.

I can submit a PR for that, if helpful.

chihirobelmo commented 1 year ago

thx, I'd like to have your PR.

something I feel strange is that AL reads the binary file for option, changes only corresponding bytes, and overwrites. so, if AL does not have a checkbox for options, it should remain as set by BMS UI...but I also have to look into it.

arithex commented 1 year ago

Draft PR for discussion => https://github.com/chihirobelmo/FalconBMS-Alternative-Launcher/pull/98

That's the quick-fix. I feel like the "right" long-term fix is either (a) add a proper checkbox for 'Show Mirrors' alongside 'Pilot Model' et al .. or (b) remove all the duplicated settings (if BMS 2d Setup UI is not dead code).