chihirobelmo / FalconBMS-Alternative-Launcher

Configure and save FalconBMS setup per Joysticks.
Other
131 stars 30 forks source link

Don't zero out 'Show Mirrors' flag when writing 'Show Pilot Model' flag. #98

Closed arithex closed 1 year ago

arithex commented 1 year ago

NOT TESTED .. just a quick and dirty PR for sake of discussion.

Issue => https://github.com/chihirobelmo/FalconBMS-Alternative-Launcher/issues/97

Q: Do we want to do a quick, surgical fix.. or should we reconsider whether AL should duplicate all of these "green checkbox" config options in the pop file .. smart scaling, pilot model, etc?

I don't fully understand the original rationale, for duplicating these in AL. (It seems like the only thing AL needed to write in the pop file is the path to the key file.)

But I also don't know enough of current plan and state of 4.38 development, to have an opinion -- viz. is new work being done on the BMS 2d experience? or is the strategy to migrate more of the UI for those various Graphics/Sound/Simulation settings (and cfg file settings) into AL?

chihirobelmo commented 1 year ago

Q: Do we want to do a quick, surgical fix.. or should we reconsider whether AL should duplicate all of these "green checkbox" config options in the pop file .. smart scaling, pilot model, etc? I don't fully understand the original rationale, for duplicating these in AL. (It seems like the only thing AL needed to write in the pop file is the path to the key file.)

well, I thought those options in the Falcon UI or in the CFG file looked easy to miss for new users though I think those are unique features of BMS... that's why I added them to AL. Maybe I can just enable them by default or make them more appealing in Falcon UI instead in the future.

But I also don't know enough of current plan and state of 4.38 development, to have an opinion -- viz. is new work being done on the BMS 2d experience? or is the strategy to migrate more of the UI for those various Graphics/Sound/Simulation settings (and cfg file settings) into AL?

a new way of the config file has been discussed for a short time... but no one has started to code yet. for now, this quick fix should be okay but ideally, I want BMS a new Falcon config file that can be editable by a user but also UI can save the status...

chihirobelmo commented 1 year ago

thx for the fix!