search

chihyingho / pe

0 stars 0 forks source link

Error in Add Menu Item Command Sequence Diagram #18

Open chihyingho opened 2 years ago

chihyingho commented 2 years ago

image.png

Self-called commands have missing activation bars.

nus-pe-bot commented 2 years ago

Team's Response

Based on my knowledge, self message and recursive messages are different. Self messages don't have activation bar but only recursive message have?

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Under W10.2, an activation bar is drawn when an object calls another of its own methods within a method. The relevant section is reproduced below: image In this case, the AddMenuItemCommand object's construction method is calling its own checkEmptyField method, so an activation bar should be present here.
I think the PE section of the module website specifies that notations not compliant with the module can be flagged out: image