search

chihyingho / pe

0 stars 0 forks source link

Failure to Detect Invalid Dates #2

Open chihyingho opened 2 years ago

chihyingho commented 2 years ago

image.png

I am allowed to key in an invalid departure date "45012022" as my flight date. I understand that the User Guide has stated that this field can be of any format. However, ensuring valid dates is critical to the purpose of this app, which concerns flight scheduling.

soc-se-bot commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Date checking in addRoute

Allows me to add a non-existent date, does not check for proper date formatting.

image.png

image.png

image.png

[original: nus-cs2113-AY2122S2/pe-interim#445] [original labels: type.FunctionalityBug severity.High]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for pointing out.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

:question: Issue type

Team chose [type.FunctionalityBug] Originally [type.FeatureFlaw]

Reason for disagreement: I believe this is a feature flaw rather than a functionality bug. A functionality bug occurs when a function does not work as specified. However, it was specified in the UG that the date field would take in inputs in any format: image

This is a feature flaw because the lack of format restrictions on the date field results in the solution to the target problem being greatly compromised.

:question: Issue severity

Team chose [severity.High] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]