chihyingho / pe

0 stars 0 forks source link

Failure to Detect Infeasible Flight Bookings #7

Open chihyingho opened 2 years ago

chihyingho commented 2 years ago

The flight booking function correctly ensures that customers cannot book flights that clash in timing (at the same time). However, it should also be checking that flight bookings that are at different times but still infeasible (e.g. departure of 2nd flight is before landing of 1st flight) cannot be made. Consider making landing time an attribute.

nus-pe-script commented 2 years ago

Team's Response

Thank you for your suggestion. However, this is beyond the scope of the current version of our application. We will consider this in future iterations.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: image

I believe that your team did consider clashing flights as within its scope, given that it is specified in the UG that users would not be able to book flights that take off at the same time. Given this, it does appear that this flaw makes the feature incomplete. Further, not checking for clashing flight timings properly does significantly hinder the application's core purpose (which is to schedule flight bookings) and does appear to be a feature that wasn't designed properly rather than out of scope.