search

chiiya / passes

PHP library for creating iOS and Android Wallet Passes
MIT License
36 stars 16 forks source link

Add GroupingInfo->groupingId as per docs #11

Closed kerattila closed 1 year ago

kerattila commented 1 year ago

Hi,

Chiiya\Passes\Google\Components\EventTicket\GroupingInfo should contain a property named $groupingId as described in docs: https://developers.google.com/wallet/generic/rest/v1/GroupingInfo

chiiya commented 1 year ago

Shouldn't that be part of the BaseObject, since it's available for all passes? I think in general since the Wallet rebranding quite a few properties have changed.

kerattila commented 1 year ago

Yes, indeed. I will do this small adjustment. Btw, would you accept a PR for generic passes? https://developers.google.com/wallet/generic/rest/v1/genericobject

chiiya commented 1 year ago

Thanks!

Btw, would you accept a PR for generic passes?

Yes, sure. Any change that'll bring us closer to being up-to-date with the recent changes is appreciated.