chiiya / passes

PHP library for creating iOS and Android Wallet Passes
MIT License
36 stars 16 forks source link

Implement a workaround for compatibility with legacy openssl pkcs12 files #19

Closed Synchro closed 1 year ago

Synchro commented 1 year ago

This is a fix for the issue I ran into in https://github.com/chiiya/laravel-passes/issues/16.

I adapted this code from the workaround used in the php-pkpass project but improved it a bit (IMHO!).

With this code in place, I can now generate signed pkpass files with PHP 8.2 and openssl 3.x.

It also includes a minor tweak to the code that creates a temp directory which avoids a warning and the need to use @, while still avoiding the race condition, as a separate commit if you want to cherry-pick.

Synchro commented 1 year ago

Hi, is there any chance you could merge this? I'm keen to avoid having to maintain my own fork! Sorry to hassle you.

Synchro commented 1 year ago

Thank you!

chiiya commented 1 year ago

Thanks for the contribution! Released as 0.5.0