I didn't correct all the "errors" for various reasons but these were the safest ones that I could see were pretty easy to deal with.
It is mostly whitespace but also a logging formatting vs. arguments issue. "logging-not-lazy" error.
As an aside,a lot of the unused outs and errs could probably be fixed by replacing Popen with check_output or just call in one case (at least) but that would require some testing and thinking about deadlocking, performance, etc. etc.
chilcote
commented
8 years ago
Hopping on the pylint bandwagon.
I didn't correct all the "errors" for various reasons but these were the safest ones that I could see were pretty easy to deal with.
It is mostly whitespace but also a logging formatting vs. arguments issue. "logging-not-lazy" error.
As an aside,a lot of the unused outs and errs could probably be fixed by replacing Popen with check_output or just call in one case (at least) but that would require some testing and thinking about deadlocking, performance, etc. etc.