search

childmindresearch / bids2table

Efficiently index large-scale BIDS neuroimaging datasets and derivatives
https://childmindresearch.github.io/bids2table/
MIT License
13 stars 5 forks source link

Suggestion: By default stop inheritance when reaching root #15

Closed adelavega closed 1 year ago

adelavega commented 1 year ago

https://github.com/cmi-dair/bids2table/blob/886d184bd28d937dc9fc9ec6531c31add343dccd/bids2table/extractors/_inheritance.py#L23

I might suggest making the default stopping rule finding the dataset_description.json file rather than 4 levels of depth, which could cause errors in some datasets.

clane9 commented 1 year ago

Sounds good, thanks for the suggestion!