childmindresearch / niftyone

Large-scale neuroimaging visualization using FiftyOne
MIT License
2 stars 2 forks source link

NiftyOne crashes using first command (`participant`) #18

Open nx10 opened 1 month ago

nx10 commented 1 month ago
26it [00:00, 97.32it/s, tot=26, good=26, rec=130, err=0]
Traceback (most recent call last):
  File "C:\Users\floru\mambaforge\envs\niftione\lib\site-packages\niclips\figures\multi_view.py", line 197, in slice_video
    writer.put(frame)
  File "C:\Users\floru\mambaforge\envs\niftione\lib\site-packages\niclips\io.py", line 36, in put
    self.init_stream(width=img.width, height=img.height)
  File "C:\Users\floru\mambaforge\envs\niftione\lib\site-packages\niclips\io.py", line 48, in init_stream
    assert isinstance(self._stream, VideoStream)
AssertionError

OS: Windows

kaitj commented 1 month ago

Thanks! With regards to the issue - there's no indication from anything in the code that would suggest this shouldn't work in Windows. The dependencies are all available cross-platform. Only thing I can think of at the moment is either:

  1. ~Something with the pathing when it gets ingested and manipulated within the codebase.~ (The updated CI run with Windows testing seems to suggest this isn't an issue).
  2. Codec not being available and stream not actually being created?

This is probably also good note to set up our actions to run on a matrix of OS's. I'm not sure if gh actions has any MacOS runners (I think maybe the old intel-based ones, not sure about their new M chips). Currently only testing with ubuntu.