childmindresearch / niftyone

Large-scale neuroimaging visualization using FiftyOne
MIT License
2 stars 2 forks source link

Add unit tests #8

Closed kaitj closed 4 months ago

kaitj commented 4 months ago

Another large PR - this time adding unit tests to niftyone. Tried to summarize everything below, but may have missed a few things:

I think some of these tests could probably go even more in depth than they are, but this brings the coverage up and should hopefully help to catch issues as any code gets refactored and extended. There was 1 line (I think in render?) where it called mux_one from the av library, that I couldn't figure out how to test / cover.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.84%. Comparing base (72410f5) to head (adbcd66).

:exclamation: Current head adbcd66 differs from pull request most recent head 2f7bff3. Consider uploading reports for the commit 2f7bff3 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8 +/- ## ========================================== + Coverage 5.87% 99.84% +93.97% ========================================== Files 24 16 -8 Lines 1022 631 -391 ========================================== + Hits 60 630 +570 + Misses 962 1 -961 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.