search

childmindresearch / niftyone

Large-scale neuroimaging visualization using FiftyOne
MIT License
4 stars 2 forks source link

Add dynamic label generation #9

Closed kaitj closed 5 months ago

kaitj commented 6 months ago

This PR changes label generation (i.e. QC metrics) from the static metrics defined in niftyone.labels to using Fiftyone's DynamicEmbeddedDocument object and setting dynamic=True for dynamically adding labels to the dataset as they are encountered. The label groups are determined by the BIDS suffix (e.g. T1w, Bold, etc.) and prepended with "QC". Additionally, the metrics are pulled from the headers of the group metric file, while the values are still being pulled from the rows.

Also removed the niftyone.labels sub-module since it is no longer needed.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.84%. Comparing base (0818498) to head (bc89013).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9 +/- ## ======================================= Coverage 99.84% 99.84% ======================================= Files 16 16 Lines 631 631 ======================================= Hits 630 630 Misses 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

clane9 commented 5 months ago

This is perfect, thanks @kaitj!