chili-epfl / FROG

Fabricating and running orchestration graphs
https://github.com/chili-epfl/FROG/wiki
Other
82 stars 27 forks source link

[Editor] Form to create new activities #5

Closed lfaucon closed 8 years ago

lfaucon commented 8 years ago

In the Editor component create a form to add new activities:

The form should have the given fields:

houshuang commented 8 years ago

Note that there are really good form components for React existing. Since we will probably need a bunch of forms in our app, it would be good to explore these and choose one, instead of building it all from hand (they offer things like validation, constraining to a certain kind of input, etc).

lfaucon commented 8 years ago

@palexlee other issues have been merged to the develop branch since you started working on issue-5, including few changes, in particular, the renaming of "quizz" to "quiz". I advise you to merge the develop branch to your current branch before going on.

lfaucon commented 8 years ago

I updated the issue description for the video activity type. We can also work with youtube urls for now, if it makes it easier for you.

mj2905 commented 8 years ago

Just some questions about this issue : The field to choose the video to upload should choose among the user device files, or is it just some path that he/she inserts like some text ? (Or, as I just read carefully the statement, do we have to choose between the 2 fields for videos, or do we have to implement both and let the user choose ?) For the quiz, do we have to suppose that the user will put an answer from the choices he has put before, or do we have to check that he/she is not putting something wrong ?

lfaucon commented 8 years ago

For the video, you have to imagine a professor creating a learning activity. He will add a new video, so two things make sense for me:

{ 
    ...,
    object: {
        path: "path/to/where/the/video/is/on/our/server"
    }
}
{ 
    ...,
    object: {
        url : "www.youtube.com......"
    }
}

You should implement at least one of these solutions to create video learning activities

I hope I am clear in my explanation. Don't hesitate to ask more question :)

mj2905 commented 8 years ago

Yeah, I see. Thank you for the clarification.

mj2905 commented 8 years ago

Another question : We talked with Thanasis about the activities, and he said that there must be a duration for an activity. As we are using the activities for the graph creation, and that we will need this duration (the graph uses the time), do we implement this now ?

lfaucon commented 8 years ago

@mj2905 Yes, you are right. I left it out for now to not give you too much to do, but if you identify it as a requirement, it would be nice to add it for sure! The project is not very mature yet and we don't know all the requirements and final structure, so it is great if you can tell us what we need and the details we missed. Thanks