Remove warnings or make documentation about those warnings more explicit.

[aperritano]

From the docs: "Some warnings when you start Meteor like missing bcrypt, hiredis etc are OK, as long as the final lines are:.."

There should be a clean console to some degree. Missing modules slows restart. Missing bcrypt slows restart. If they are missing and its ok; why not just take the references out?

can this be taken care of in the inital_setup script?

Unable to resolve some modules:

"bufferutil" in /Users/aperritano/dev/CK-FROG/frog/node_modules/ws/lib/BufferUtil.js (os.osx.x86_64) "utf-8-validate" in /Users/aperritano/dev/CK-FROG/frog/node_modules/ws/lib/Validation.js (os.osx.x86_64) "hiredis" in /Users/aperritano/dev/CK-FROG/frog/node_modules/redis-parser/lib/hiredis.js (os.osx.x86_64)

If you notice problems related to these missing modules, consider running:

meteor npm install --save bufferutil utf-8-validate hiredis

W20171205-15:26:34.622(-6)? (STDERR) Note: you are using a pure-JavaScript implementation of bcrypt. W20171205-15:26:34.623(-6)? (STDERR) While this implementation will work correctly, it is known to be W20171205-15:26:34.623(-6)? (STDERR) approximately three times slower than the native implementation. W20171205-15:26:34.623(-6)? (STDERR) In order to use the native implementation instead, run W20171205-15:26:34.623(-6)? (STDERR) W20171205-15:26:34.623(-6)? (STDERR) meteor npm install --save bcrypt W20171205-15:26:34.623(-6)? (STDERR) W20171205-15:26:34.624(-6)? (STDERR) in the root directory of your application.

[juancarlosfarah]

I agree with @aperritano. I spent some time looking for why hiredis was missing after seeing the warning:

Unable to resolve some modules:

  "hiredis" in /Users/juancarlosfarah/code/graasp/services/graasp-service-frog/frog/node_modules/redis-parser/lib/hiredis.js
(os.osx.x86_64)

If you notice problems related to these missing modules, consider running:

  meteor npm install --save hiredis

I didn't even know if it was a warning or an error, as it is not indicated in the terminal output.

[houshuang]

The problem is stupid packages that look for some module, but then switch on whether the module is available or not, because it's actually optional. And in the case of hiredis, it's even not recommended... I could just install hiredis, but it kind of goes against my beliefs to do that just because a package is poorly configured...

(What we should fix is all the warnings when you run yarn on initial_setup about missing peer dependencies... Someone just has to sit down and figure them all out)

On Fri, May 18, 2018 at 1:55 PM, Juan Carlos Farah <notifications@github.com

wrote:

I agree with @aperritano https://github.com/aperritano. I spent some time looking for why hiredis was missing after seeing the warning:

Unable to resolve some modules:

"hiredis" in /Users/juancarlosfarah/code/graasp/services/graasp-service-frog/frog/node_modules/redis-parser/lib/hiredis.js (os.osx.x86_64)

If you notice problems related to these missing modules, consider running:

meteor npm install --save hiredis

I didn't even know if it was a warning or an error, as it is not indicated in the terminal output.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/chili-epfl/FROG/issues/724#issuecomment-390184018, or mute the thread https://github.com/notifications/unsubscribe-auth/AADwh3RJs0ZSMpPnj0zMGAaqtyo2hLD_ks5tzraogaJpZM4Q4KWg .

-- http://reganmian.net/blog -- Random Stuff that Matters

[houshuang]

hiredis warning is now gone, after upgrading Meteor. Bcrypt is weird, we have added it to package.json, don't know why it doesn't work. Help welcome.

Otherwise we should fix the warnings when doing initial_install from yarn, again, help welcome :)