chili-epfl / chilitags

Robust Fiducial Markers for Augmented Reality And Robotics
http://chili.epfl.ch/software
121 stars 57 forks source link

Optimized FindQuads #24

Closed qbonnard closed 10 years ago

qbonnard commented 10 years ago

Made FindQuads more robust to scale, and tweaked two magic values to get more true positives on the test data set. The first tweak seems like a clear improvement, the second one is debatable : while there is no new false negative, there is a slight hit on processing time. Check the individual commit messages for performance stats.

qbonnard commented 10 years ago

The detection performance of FindQuads are now comparable to FindQuadsWithLSD, if not better. Should we keep both ?

severin-lemaignan commented 10 years ago

Very impressive improvement! I'm good to merge once you've check the suggested improvement for conditional refinement.

severin-lemaignan commented 10 years ago

I'm also in favor of dropping LSD.