search

chili-epfl / chilitags

Robust Fiducial Markers for Augmented Reality And Robotics
http://chili.epfl.ch/software
123 stars 57 forks source link

FindQuad.cpp image scaling #54

Closed lorenzolightsgdwarf closed 9 years ago

lorenzolightsgdwarf commented 10 years ago

Are you sure line 72

cv::resize(greyscaleImage, mGrayPyramid[0], cv::Size(mMaxInputWidth, greyscaleImage.rows*mMinInputWidth/greyscaleImage.cols), .0, .0, cv::INTER_NEAREST)

is correct?

I think mMinInputWidth should be mMaxInputWidth...

qbonnard commented 10 years ago

:blush: a nice example of how perfect our test suite is... nice catch, thanks ! would you happen to have a related pull request ?

lorenzolightsgdwarf commented 10 years ago

The scaling done from line 70 (maxwidth), it's not taken into account when rescaling the contours (line 123). Since ReadBit works on the original image, the detection fails.

qbonnard commented 9 years ago

Fixed in https://github.com/chili-epfl/chilitags/pull/55 and https://github.com/chili-epfl/chilitags/pull/56