search

chili-epfl / chilitags

Robust Fiducial Markers for Augmented Reality And Robotics
http://chili.epfl.ch/software
123 stars 57 forks source link

Max width #56

Closed qbonnard closed 9 years ago

qbonnard commented 9 years ago

hey there, so I finally come back to this. I started from @lorenzolightsndwarf 's PR (https://github.com/chili-epfl/chilitags/pull/55), added a little test, and moved the resizing/preprocessing from FindQuad to the whole detection pipeline (otherwise our friend Refine takes infinite time too) : https://github.com/qbonnard/chilitags/tree/maxWidth How about this one ?

severin-lemaignan commented 9 years ago

Any benchmark results to share? (while waiting for travis to check your PR is ok :-))

qbonnard commented 9 years ago

No serious ones... What test cases are you thinking about ? I guess it's fairly easy to add some tests to the detection performance.

qbonnard commented 9 years ago

Travis does not complain. Merging once... Merging twice... (If you want me to sleep at night, please rebase, or let me do it, but please don't hit the "Merge pull request" button ;) )