Closed ayberkozgur closed 9 years ago
Ah yeah, there was already a PR like that from some time ago, what happened to it ? Still a good idea to me, would you like to add a simple test ? Yeah, that's my new thing these days ;) A single call to read the configuration from a string in the test suite would make me happy ;)
Is anyone interested in reviewing this in the coming days? Otherwise I'm just going to go ahead and merge it.
I would, if you don't ignore my request for test ;) Or is there a filter in Chili that drops any message containing "test" ? Looks like @severin-lemaignan did not get them either in https://github.com/chili-epfl/chilitags/pull/61 :p
What, did someone say test? I couldn't hear anything... :D
I tried to run the included tests in Chilitags as they are, but I'm getting
In file included from /home/equilibrium/src/chilitags/test/detection-performance.cpp:22:0:
/usr/include/opencv2/ts.hpp:7:22: fatal error: cvconfig.h: No such file or directory
#include "cvconfig.h"
that was supposed to be fixed by some PR months ago in OpenCV. Any ideas?
Are you using Precise's default opencv installation ? Not much to do, except upvote this bug report ;) https://bugs.launchpad.net/ubuntu/+source/opencv/+bug/1315418
For the tests, I end up using my own compilation of opencv (yay).
Also, glad to see that you have been using the test suite extensively before ;) FWIW, I run them everytime I "save all" in my text editor, after compiling of course, and I've found them to be a huge timesaver to make sure I haven't broken anything. I really regret al the time wasted running a sample demo, moving the webcam onto a tag, and checking a printf...
No of course, I've always custom building my OpenCV, and it's the 3.0.0-alpha
tag now that's NOT building. I'm kinda getting fed up with this fragmented and easygoing development of OpenCV...
Not to mention horrible documentation...
I'm on the 2.4.8 branch, if that helps... I think the "alpha" part of 3.0.0-alpha
means that you don't get to complain ;)
@severin-lemaignan , please stop @ayberkozgur before he starts his own CV library. Hurry !
Unfortunately 3.0.0-alpha
and on has NEON improvements that I simply can't regress behind.
Also, I looked at the cvconfig.h
that's not being installed; it seems to be the predecessor of opencv_modules.hpp
. Why is cvconfig.h
still being referenced in ts
? Any ideas?
None whatsoever !
OK, added the appropriate test for this PR as well as some polishing on that part of tests.
Merged ! Thanks ! And thanks for the test. We will debate over the aesthetics of white spaces on another PR ;)
This PR enables the option of reading the tag configuration from the string instead of a file. This will allow reading tag configs in environments where regular file system access assumptions cannot be made, such as packaging the file with a
qrc
.This PR does not break existing functionality in the user code.