search

chili-epfl / chilitags

Robust Fiducial Markers for Augmented Reality And Robotics
http://chili.epfl.ch/software
123 stars 57 forks source link

Integrate test data as a submodule #64

Closed ayberkozgur closed 9 years ago

ayberkozgur commented 9 years ago

Is there a good reason for having test share in a separate repo? Is it that big (currently it looks like 34M), or do we expect it to become huge in the future?

If there's a good reason, it should at least be a git submodule.

qbonnard commented 9 years ago

Two reasons:

  1. annoy Séverin
  2. make sure people are not afraid to bloat the code repository by adding test data. TEST ALL THE THINGS !

So yeah, I would still keep it separate. 35M is already quite big to my taste, most people don't care about the tests (don't you dare telling me otherwise), and again, people should feel free to add test cases with real data. Is that enough good reasons ?

The submodule is a good idea, so we can keep track of which commit works with which version of the test data.

ayberkozgur commented 9 years ago

@qbonnard well, reason 1 was already enough for me, you didn't have to list more after that XD.

Ok joking aside, I see your point, it might encourage people to add tests no matter the size (we're talking mainly about video content here).

I'm definitely not going to tell you that people care about tests, because they don't :)

So I'm submoduling the test data as soon as possible then?

severin-lemaignan commented 9 years ago

ok for me.