search

chili-epfl / chilitags

Robust Fiducial Markers for Augmented Reality And Robotics
http://chili.epfl.ch/software
123 stars 57 forks source link

Separated pnp, rodrigues and related stuff into its own object #74

Closed ayberkozgur closed 9 years ago

ayberkozgur commented 9 years ago

This shortens and simplifies Chiltiags3D a little bit and also will allow a cleaner next step which is noise filtering on the 3D pose and then the integration of the IMU if present.

This is a purely refactoring PR, API/performance is not changed.

qbonnard commented 9 years ago

Nice ! It's all good to me, except for the password as a class name ;) How about Estimate3DPose ?

ayberkozgur commented 9 years ago

I think it's good to merge now.

qbonnard commented 9 years ago

Maybe we can start with this one ? I think it's ready to merge... Do you want me to rebase it, or do you want to ?

On Sat, Nov 22, 2014 at 11:30 AM, Ayberk Özgür notifications@github.com wrote:

I think it's good to merge now.

— Reply to this email directly or view it on GitHub https://github.com/chili-epfl/chilitags/pull/74#issuecomment-64075927.

ayberkozgur commented 9 years ago

I'm rebasing this right now.

ayberkozgur commented 9 years ago

Ready to merge

qbonnard commented 9 years ago

Perfect, thanks !