search

chili-epfl / chilitags

Robust Fiducial Markers for Augmented Reality And Robotics
http://chili.epfl.ch/software
123 stars 57 forks source link

Do not install sample binaries #80

Closed ayberkozgur closed 9 years ago

ayberkozgur commented 9 years ago

It's really not a good idea.

qbonnard commented 9 years ago

... because ?

skadge commented 9 years ago

because chilitags is a library, and the normal expectation is that a library install 2 things: headers and the library itself.

To also install test/sample apps by default is not a good practise (if only because those applications are not meant to be actually used by the library user). One option is to have a CMake option called "INSTALL_SAMPLES" which should be off by default.

Tools (like the tag creator) are a different story, and I'm fine with installing those by default.

ayberkozgur commented 9 years ago

Also, even if I wanted to install samples, I wouldn't want a binary in my PATH that is called detect-live :)

ayberkozgur commented 9 years ago

Solved by 122b66da09d9f26857455b4fa7709c4db3eb162c.