There should not be ifdefs in header

chili-epfl / chilitags

Robust Fiducial Markers for Augmented Reality And Robotics

http://chili.epfl.ch/software

123 stars 57 forks source link

Closed ayberkozgur closed 9 years ago

ayberkozgur commented 9 years ago

#ifdef HAS_MULTITHREADING I added in chilitags.hpp is forcing the user to #define HAS_MULTITHREADING. This is not cool.

ayberkozgur commented 9 years ago

Solved by 8dfb5ae002a4646d2b88aed7dd5c2a6c2d1d8776.

qbonnard commented 9 years ago

So what was wrong with #ifdefs in header ?

ayberkozgur commented 9 years ago

You had to

#define HAS_MULTITHREADING
#include<chilitags/chilitags.hpp>

which is annoying.