chili-epfl / orchestration-graphs

Workflow engine for orchestration graphs
http://classroom.ai/
6 stars 2 forks source link

Ambiguous graphs when repeating the same activity #1

Closed thibaultcalvayrac closed 8 years ago

thibaultcalvayrac commented 8 years ago

Considering the following graph

Image of Yaktocat

The json would be: {"activities":[{"id":1}, {"id":2}, {"id":3}], "edges":[{"a1":1, "a2":1}, {"a1":1, "a2":2}, {"a1":1, "a2":3}, {"a1":2, "a2":3}], "start":1}

The problem is that nothing differentiates the two 1s. This leads to various issues:

@rphkhr proposed a solution: we modify the json format by adding a counter for each activity id, something like: {"activities":[{"id":1, "count":1}, {"id":1, "count"=2}, {"id":2, "count":1}, {"id":"3", count:"1"}], "edges":[{"a1":{"id":1, "count":1}, "a2":{"id":1, "count"=2}}, {"a1":{"id":1, "count"=1}, "a2":{"id":2, "count"=1}}, {"a1":{"id":1, "count"=2}, "a2":{"id":3, "count"=1}}, {"a1":{"id":2, "count"=1}, "a2":{"id":3, "count"=1}}], "start":1}

ritterni commented 8 years ago

Yeah, sounds like a decent solution.

ritterni commented 8 years ago

Why is this closed?