search

chilijung / react-native-image-page

react-native image-carousel with zoom-pan gestures and full-screen support, work on both iOS and Android
20 stars 8 forks source link

Solving #3: android switch image page will trigger onPress method #4

Closed iesteban closed 7 years ago

iesteban commented 7 years ago

It works quite properly. But if you switch the images very fast, it triggers the onPress method.

chilijung commented 7 years ago

hi @iesteban, I thought this is a good fix. Why are you closing this PR? What are you considering?

iesteban commented 7 years ago

Hi @chilijung,

That fix raises a warning about not passing an object to pressRetentionOffset , to avoid the warning the line should be: pressRetentionOffset={{top: 1, left: 1, bottom: 1, right: 1}}>

But neither high values nor low values gives a better behavior. Only worse.

chilijung commented 7 years ago

@iesteban add in v0.3.0 !