Image assumes laravel instance exists in projects root directory

chilio / laravel-dusk-ci

Docker Test suite for Laravel Dusk in gitlab CI

MIT License

159 stars 51 forks source link

Image assumes laravel instance exists in projects root directory #44

Closed Loyen closed 5 years ago

Loyen commented 5 years ago

The current image makes the assumption that the repository it's used against has the laravel instance within the root directory. If you have it in a subdirectory, the scripts fails as they assume everything is available from CI_PROJECT_DIR before moving on.

chilio commented 5 years ago

Loyen thanks for this PR. I've merged this to master->latest, however docker hub hangs/stale while building, so for no reason, we need to wait until they solve it... I've already notified docker support, but don't expect immediate reaction...

Loyen commented 5 years ago

It was totally fine, I didn't expect it to get merged that fast.

Looks like it's available on chilio/laravel-dusk-ci:latest now (~9 hours ago).

Since the changes are merged and the image is available, I will close this now. Thank you!