search

chilipeppr / serial-port-json-server

Serial Port JSON Server is a websocket server for your serial devices. It compiles to a binary for Windows, Mac, Linux, Raspberry Pi, or BeagleBone Black that lets you communicate with your serial port from a web application. This enables web apps to be written that can communicate with your local serial device such as an Arduino, CNC controller, or any device that communicates over the serial port.
http://chilipeppr.com
GNU General Public License v2.0
323 stars 101 forks source link

Adding more baudates #20

Open pc-coholic opened 7 years ago

pc-coholic commented 7 years ago

I am using SPJS for a project of mine which is using hardware from the last century... That hardware - unfortunately - requires a 600 Baud connection.

Therefore, I would like to propose to add that speed also to the stack of supported baudrates.

For ease of merging, I have created a pullrequest johnlauer/goserial/pull/2 which backports all the upstream supported baudrates. As SPJS originated in johnlauer's repo, you can probably chip in to have this merged, too, right? :-)

Thanks :)

chilipeppr commented 7 years ago

Hmm. The problem I have with this is that it will make the pulldown menu in ChiliPeppr confusing to see all those baud rates and the value they add for the broad set of users is not worth it. The balance here would be to let you be able to open the port at that baud rate, but not have those values come back in the supported baud rate list such that UI's don't bother showing the rates you added.

pc-coholic commented 7 years ago

I'm fine with that, too :-)

In that case, you can just close this pull-request and not merge it, as it will work with the goserial-backend now accepting those other baudrates.