search

chilipeppr / serial-port-json-server

Serial Port JSON Server is a websocket server for your serial devices. It compiles to a binary for Windows, Mac, Linux, Raspberry Pi, or BeagleBone Black that lets you communicate with your serial port from a web application. This enables web apps to be written that can communicate with your local serial device such as an Arduino, CNC controller, or any device that communicates over the serial port.
http://chilipeppr.com
GNU General Public License v2.0
322 stars 101 forks source link

Update bufferflow_grbl.go #23

Closed lunix80 closed 7 years ago

lunix80 commented 7 years ago

Adding extra regex match to send directly to the serial port new real-time commands of grbl v1.1

chilipeppr commented 7 years ago

Looks good.

chilipeppr commented 7 years ago

I don't think you need those parentheses in your regex as that would just create a grouping and you never do a back reference to look at the grouping. Doesn't really change the behavior though, just one extra memory allocation.

chilipeppr commented 7 years ago

Pull request merged and 1.94 released. https://github.com/chilipeppr/serial-port-json-server/releases/tag/v1.94

Good work on changes.

On Mon, Jan 16, 2017 at 3:29 PM, Luca notifications@github.com wrote:

@lunix80 commented on this pull request.

Buffer decreased from 127 to 125 bytes to be safe

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/chilipeppr/serial-port-json-server/pull/23#pullrequestreview-16898963, or mute the thread https://github.com/notifications/unsubscribe-auth/AHidbYMQ2M8AJ0Rb-D0KWPuF_6i9KHtUks5rS_0_gaJpZM4Lk-ei .